Add a 'Close Display' action#3437
Merged
shroffk merged 2 commits intoJul 15, 2025
Merged
Conversation
Contributor
Author
|
Would it be possible to get some feedback on this new feature? |
Contributor
Author
|
I have checked that all resources are tidied up by this new action to close a display and I can confirm that the method I call to close the display calls DockItem.prepareToClose(): which performs checks to make sure that it is OK to closer the display: This is the same method called when you click the cross on the top of a display, therefore I conclude that resources are cleaned up in the same way. I have also used the PV List app in Phoebus to confirm that when you close a display using the new action in an action button, the connections to the PVs are closed and the PV List shows that no PVs are in use. |
Member
|
@rjwills28 thank you for double checking |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I looked into adding a dedicated 'close display' action that can be used in ActionButtons. This is following my request in #3384.
As I explain in that issue, it is nice to have some redundancy in screens and so offer the user multiple ways to close the display, i.e. in addition to the 'x' at the top of the display/window. Note, that as also explained in that issue, this isn't always an option if you have 'Always show tabs' disabled and you are using split windows.
This is a simple action that just closes the current display.
Please let me know what you think?